Skip to content

try to fix tests#291

Merged
severo merged 12 commits intomasterfrom
fix-test
Oct 6, 2025
Merged

try to fix tests#291
severo merged 12 commits intomasterfrom
fix-test

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented Oct 6, 2025

@severo
Copy link
Copy Markdown
Contributor Author

severo commented Oct 6, 2025

well, it removes warnings, but it's not the cause of the tests errors. It might be related to the timeout, because the tests take too long to run.

@severo
Copy link
Copy Markdown
Contributor Author

severo commented Oct 6, 2025

Maybe it's due to the Node.js version in the runner?

Node.js 20.19.5

edit: I don't reproduce the error locally by using this version.

@severo
Copy link
Copy Markdown
Contributor Author

severo commented Oct 6, 2025

OK, increasing the test timeout fixes one of the two errors. It's a patch, and we shouldn't have to rely on it. Opened #292.

Still one error, that I cannot reproduce locally:

 FAIL  src/components/HighTable/HighTable.test.tsx > with async data, HighTable > aborts data fetch when scrolling fast
AssertionError: promise rejected "TestingLibraryElementError: Unable to fin…" instead of resolving
 ❯ src/components/HighTable/HighTable.test.tsx:352:58
    350|       expect(asyncData.getCell).toHaveBeenCalledWith({ row: 50, column…
    351|     })
    352|     await expect(findByRole('cell', { name: 'async 50' })).resolves.to…
       |                                                          ^
    353| 
    354|     expect(asyncData._forTests.signalAborted).toHaveLength(1) // one f…
Caused by: TestingLibraryElementError: Unable to find role="cell" and name "async 50"

@severo severo changed the title import act from the testing library try to fix tests Oct 6, 2025
@severo
Copy link
Copy Markdown
Contributor Author

severo commented Oct 6, 2025

not fixed either by upgrading the dependencies: #293

@severo severo mentioned this pull request Oct 6, 2025
@severo
Copy link
Copy Markdown
Contributor Author

severo commented Oct 6, 2025

trying to re-run a successful test from a previous commit: https://github.com/hyparam/hightable/actions/runs/18139377744/job/51626243016

=> https://github.com/hyparam/hightable/actions/runs/18139377744/job/52030917528 - it now fails...

Hmm, not sure what to do. Let's disable the test and open an issue for this (#294).

@severo severo merged commit 9e84bf3 into master Oct 6, 2025
5 checks passed
@severo severo deleted the fix-test branch October 6, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant