Fix flaky async abort test by using fake timers (#294)#301
Merged
platypii merged 1 commit intohyparam:masterfrom Oct 13, 2025
Merged
Fix flaky async abort test by using fake timers (#294)#301platypii merged 1 commit intohyparam:masterfrom
platypii merged 1 commit intohyparam:masterfrom
Conversation
Unskipped and refactored the "aborts data fetch when scrolling fast" test to eliminate timing-based flakiness observed in CI. Hypothesis: The test was flaky in CI due to timing variations between environments. Real timers with 100ms delays could behave unpredictably under varying system load, causing race conditions in async operations. Solution: - Use vi.useFakeTimers() for deterministic time control - Replace findByRole (async, uses real timers) with queryByRole (sync) - Explicitly advance timers with vi.advanceTimersByTimeAsync() - Add afterEach cleanup to restore real timers Benefits: - Test is now deterministic and immune to system timing variations - Execution time reduced from ~1370ms to ~666ms (nearly 2x faster) - Maintains test validity while eliminating CI flakiness 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
severo
approved these changes
Oct 13, 2025
Contributor
severo
left a comment
severo
left a comment
There was a problem hiding this comment.
Good idea, great contribution!
Contributor
@jpetitcolas can you sign your commits? Or @platypii do you know if we can override this restriction (squash and merge will not use initial commits anyway)? (I cannot do it myself) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unskipped and refactored the
aborts data fetch when scrolling fasttest to eliminate timing-based flakiness observed in CI.Hypothesis: The test was flaky in CI due to timing variations between environments. Real timers with 100ms delays could behave unpredictably under varying system load, causing race conditions in async operations.
vi.advanceTimersByTimeAsync())Hopefully, this test should now not be flaky anymore and run slightly faster.