Skip to content

Eslint#353

Merged
severo merged 4 commits intomasterfrom
eslint
Dec 18, 2025
Merged

Eslint#353
severo merged 4 commits intomasterfrom
eslint

Conversation

@severo
Copy link
Copy Markdown
Contributor

@severo severo commented Dec 18, 2025

  • rewrite the eslint configuration for clarity
  • use @stylistic/eslint-plugin instead of deprecated eslint rules for styling
  • use eslint-plugin-import to ensure the imports consistently use an extension (nit)
  • use eslint-plugin-simple-import-sort to ensure the types are imported in a import type {... statement
  • more default rules are used now. We could revert some if needed, but they all increase clarity, and handle the type definitions better.
  • reformat all the code

@severo
Copy link
Copy Markdown
Contributor Author

severo commented Dec 18, 2025

cc @platypii for visibility. Tell me if you're allergic to some style change.

@severo severo merged commit 42a2c69 into master Dec 18, 2025
5 checks passed
@severo severo deleted the eslint branch December 18, 2025 14:43
Copy link
Copy Markdown
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like it, some nits

Comment thread src/components/Cell/Cell.test.tsx
Comment thread src/components/ColumnHeader/ColumnHeader.test.tsx
Comment thread src/components/ColumnHeader/ColumnHeader.tsx
Comment thread src/components/Cell/Cell.test.tsx
@severo severo mentioned this pull request Dec 18, 2025
@severo
Copy link
Copy Markdown
Contributor Author

severo commented Dec 18, 2025

thanks for the review and comments; here is the fix: #357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants