Refactor to prepare two scrolling modes#356
Merged
Conversation
severo
force-pushed
the
refactor-to-prepare-two-scrolling-modes
branch
from
921a2e4 to
12a9623
Compare
Contributor
|
❤️ thank you for doing this... I do this all the time: I make a big branch, but then I try to backport as much as I can to master first so that the big PR will be as minimal as possible. A lot of engineers just put up the massive PR. Love it! 🙏 |
Contributor
Author
|
Yes, to be honest, it's also selfish: it helps me understand my own code in the big PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.