Conversation
|
wdyt @platypii? The internal code is a bit simpler, I think. But the interface to pass the data is a bit more complex (see the changes in the tests). So... not sure I feel like |
platypii
left a comment
There was a problem hiding this comment.
I like this direction. I think that having the __index__ in the same object as the columns was making the code really awkward.
The dataframe interface is okay to be a little complicated especially since we have helpers like asyncRows which can help. There might be some other helpers which could make it easier for a naive implementation (so that down stream users can just have resolved objects and not have to understand asyncrows). But also... no one besides us is using hightable yet, and we should keep evolving it to suit our needs.
|
Should update the README too |
|
OK! I'll update the README and merge. |
This PR is a breaking change in the dataframe's
rowsmethod, since it must returnAsyncRow[], instead of supporting two types:AsyncRow[] | Promise<Row[]>.Also, I separate the index from the values to avoid collisions and make the code simpler: