measure and use the header height in calculations#363
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a keyboard navigation bug where the currently focused cell was hidden behind the header. The fix measures the actual header height and uses it in scroll calculations to ensure proper cell visibility.
Key changes:
- Refactored
setTableCornerWidthtosetTableCornerSizeto track both width and height of the table corner - Added
headerHeightcalculation in Wrapper component using the measured table corner height - Updated scroll height calculation in Scroller to account for the actual header height
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/TableCorner/TableCorner.tsx | Changed callback from setTableCornerWidth to setTableCornerSize to measure both width and height of the table corner element |
| src/components/HighTable/Wrapper.tsx | Updated state to track full table corner size, calculated headerHeight from measured dimensions, and passed it to child components |
| src/components/HighTable/Slice.tsx | Updated prop type to accept setTableCornerSize instead of setTableCornerWidth |
| src/components/HighTable/Scroller.tsx | Added headerHeight prop and updated scroll height calculation to use it, ensuring accurate positioning when scrolling to cells |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes a bug when navigating with the keyboard.
Before, the current cell was hidden by the header
Screencast.From.2025-12-22.15-59-55.mp4
Now, it's visible
Screencast.From.2025-12-22.16-00-20.mp4