Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a notifyChange callback prop to the useInputState hook, which is called whenever the state value changes, regardless of whether the component is in controlled or uncontrolled mode. This differs from the existing onChange callback, which is only called for user-initiated changes.
Changes:
- Added
notifyChangeprop toUseInputStatePropsinterface with detailed documentation - Updated implementation to track controlled value changes and call
notifyChangeappropriately - Improved docstrings for the hook's return type
- Comprehensive test coverage for the new
notifyChangefunctionality in both controlled and uncontrolled modes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/hooks/useInputState.ts | Adds notifyChange prop, updates state management to detect controlled value changes and invoke the callback, improves documentation |
| test/hooks/useInputState.test.ts | Adds comprehensive tests for notifyChange behavior in both controlled and uncontrolled modes, verifies it's not called on init but is called on value changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…d (the local state has been committed)
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will be used later to react to changes in the controlled value.
Also improve docstrings, and rework the useInputState tests.