Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors internal table state so numColumns is sourced from DataProvider via context (per #449), instead of being passed down as a prop, reducing prop threading and helping minimize re-renders.
Changes:
- Add
NumColumnsContext/useNumColumns()toDataContext, and provide the initial column count fromDataProvider. - Update
ColumnWidthsProviderto consumenumColumnsfrom context; updateHighTableto stop passingnumColumns. - Update tests to validate
numColumnsprovisioning and adaptColumnHeadertests to the new context dependency.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/providers/DataProvider.test.tsx |
Extends provider tests to assert numColumns behavior (including immutability expectation). |
src/providers/DataProvider.tsx |
Provides numColumns via a new context, keeping the initial value stable per data instance. |
src/providers/ColumnWidthsProvider.tsx |
Removes numColumns prop; reads numColumns from DataContext. |
src/contexts/DataContext.ts |
Introduces NumColumnsContext and useNumColumns(). |
src/components/HighTable/HighTable.tsx |
Stops passing numColumns into ColumnWidthsProvider. |
src/components/ColumnHeader/ColumnHeader.test.tsx |
Wraps tests with NumColumnsContext.Provider to satisfy new dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #449