Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors column descriptor handling so column descriptors (and derived column count) are owned by DataProvider and treated as “initial, stable” values to reduce re-renders and avoid unsupported runtime updates to column descriptor properties (per #449).
Changes:
- Add
ColumnDescriptorsContexttoDataProviderand initialize it from the data frame’s initialcolumnDescriptors. - Update
ColumnParametersProviderto read column descriptors fromDataContextinstead of receiving them as a prop. - Update affected tests and
HighTablewiring to align with the new context-driven API.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/providers/ColumnParametersProvider.test.tsx | Wraps ColumnParametersProvider in ColumnDescriptorsContext.Provider for updated dependency. |
| src/providers/DataProvider.tsx | Introduces ColumnDescriptorsContext provider and stores initial column descriptors for stability. |
| src/providers/ColumnParametersProvider.tsx | Switches to useColumnDescriptors() and removes columnDescriptors prop. |
| src/contexts/DataContext.ts | Adds ColumnDescriptorsContext and useColumnDescriptors() hook. |
| src/components/HighTable/HighTable.tsx | Removes passing data.columnDescriptors into ColumnParametersProvider; relies on DataProvider. |
| src/components/ColumnHeader/ColumnHeader.test.tsx | Updates test setup to provide ColumnDescriptorsContext. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the number of rerenders + fix the value to the initial value (we don't have a mechanism to update the columns name, sortable property or number)
see #449