Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the refactor from issue #449 by moving the exclusiveSort flag out of direct data access and into the data-layer context so consumers can read a stable, initial value and reduce unnecessary prop plumbing.
Changes:
- Add
ExclusiveSortContext+useExclusiveSort()toDataContext. - Initialize
exclusiveSortonce inDataProvider(fixed to the data frame’s initial value) and provide it via context. - Update
HighTable/Sliceto consumeexclusiveSortfrom context instead ofdata.exclusiveSort.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/providers/DataProvider.tsx | Captures exclusiveSort on mount and provides it via a new context provider. |
| src/contexts/DataContext.ts | Introduces ExclusiveSortContext and a useExclusiveSort hook for consumption. |
| src/components/HighTable/Slice.tsx | Switches TableHeader’s exclusiveSort prop source to the new context hook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #449