Conversation
hasCompleteRow can be computed, no need to persist it in the state. It's fast because we don't have more than 50-100 rows. Also: I renamed SET_ROWS into FETCHED_ROWS_SLICE, as conceptually a resolver takes action and decide what to do with it. But the action as itself only described an event that occurred, not what the resolver should do with it. Anyway, it's a NIT
platypii
approved these changes
Feb 26, 2025
Contributor
platypii
left a comment
platypii
left a comment
There was a problem hiding this comment.
I'm amazed this was able to be simplified so much! Changes look good. Hard to predict some of the edge cases in state management in react, but if this works, it looks like a great improvement in clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need a complex state with a reducter. It's simpler with a single state (
Slice | undefined) and easier to understand, I think.