Merged
Conversation
b2cfe38 to
0d79851
Compare
0d79851 to
76ad372
Compare
645ce4e to
238b639
Compare
10093a4 to
d2dbc16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @platypii: there are numerous TODOs in the code because there are plenty of opportunities to optimize (ie. to avoid doing the same again and again). I think we can work on optimizing in another PR (and I can better move these TODOs to a specific issue), though, because it could require changing a bit the format of DataFrame. Interested in your thoughts on how we could optimize.