Use smaller components to simplify the code#70
Merged
Conversation
platypii
reviewed
Mar 13, 2025
Contributor
platypii
left a comment
platypii
left a comment
There was a problem hiding this comment.
Nice I am in favor of splitting out files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before implementing big changes like supporting multicolumn sort, I propose simplifying the code's structure by splitting HighTable and TableHeader into smaller components. This PR is a first step in that direction, and it does not change the functionalities in any way.
Note that it allowed me to get rid of the "fake" table-corner div floating above the table. Now it's the first cell of the table, as a user would expect.
I'm merging it so that I can keep working on it, but cc @platypii as it significantly changes the structure of the code (note: it's partly inspired by https://www.joshwcomeau.com/react/file-structure/).