Fix review findings: integration/tui-prompts (hy-3a7ri)#32
Merged
Conversation
…) (PR #26) Address the three findings on integration/tui-prompts dual-review: - Contract & Interface Fidelity (major): shouldUseTui and TUI runtime now read HYP_NO_TUI/NO_COLOR through opts.env when supplied, falling back to process.env only when nothing is injected. The walkthrough threads env through multiselect/text so env-injected runs flip the TUI path consistently. - Error Handling & Resilience (major): runPickerWalkthrough catches PromptCancelledError and returns exit code 130 (SIGINT convention) with a "hyp init: cancelled" stderr line, instead of letting cancels fall into the dispatcher's generic unhandled-exception path. - Release Safety (minor): replace shell find/xargs in `npm test` with scripts/run-tests.js (Node-driven, mirrors check-syntax.js). The script discovers *.test.js under test/ and execs `node --test` with the resolved paths so the suite runs on Windows shells too. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix review findings: integration/tui-prompts
Addressed all 3 findings (2 major + 1 minor) on PR #26 dual-review. Branch polecat/hy-3a7ri pushed. Tests (345), lint, typecheck, walkthrough smokes all pass. Refinery rebases onto integration/tui-prompts.
Delivery
This PR is auto-merged into the integration branch once CI is green. Human
review for the full feature happens on the downstream PR
(
integration/tui-prompts -> master), which is opened separately when the featureis ready to ship.