[ENH] sklearn 1.7 compatibility
#131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
enhancement
fkiraly
changed the title
_deprecate_Xt_in_inverse_transformsklearn 1.7 compatibility
Collaborator
Author
|
superseded by #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple compatibility fixes with
sklearn 1.7.sklearnadapter was importing the private utility fromsklearn,_deprecate_Xt_in_inverse_transform. This is fixed by removing the import and assuming the future interface.sklearnnow has a more stringent set of input checks, instead of coercions. This is handled for the two estimators simultaneously - common methods are also moved ot a common adapter class.