[MNT] Change examples to v5 + small fixes #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBlanke
force-pushed
the
change-examples-to-v5
branch
from
ed516a1 to
336fcfa
Compare
fkiraly
reviewed
Aug 19, 2025
fkiraly
requested changes
Aug 19, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
all looks good, minimal change request only, see above
fkiraly
reviewed
Aug 19, 2025
| params_regress = { | ||
| "estimator": SVR(), | ||
| "scoring": mean_absolute_error, | ||
| "scoring": "neg_mean_absolute_error", |
Collaborator
There was a problem hiding this comment.
can you add a test case instead of changing an existing one?
fkiraly
requested changes
Aug 19, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
in the sklearn example, can you add a test case instead of changing one?
fkiraly
approved these changes
Aug 20, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
I am happy with this (I fixed the sklearn compatibility tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates examples for v5 compatibility and fixes several issues preventing example tests from running successfully.