Skip to content

Conversation

@SimonBlanke
Copy link
Collaborator

Continuation of #153

@SimonBlanke SimonBlanke requested a review from fkiraly August 24, 2025 17:24
@SimonBlanke SimonBlanke changed the title Update readme fpr v5 Update readme for v5 Aug 24, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are merge conflicts with the current readme

fkiraly and others added 3 commits August 25, 2025 13:57
In `BaseExperiment` descendants, makes the following consistent:

* `__call__` signature is now `__call__(params)`, instead of
`__call__(**params)` - for consistency with `evaluate` and the expected
function/callable interface
* the second return of `score` and `evaluate` is now consistently called
"metadata" (instead of `add_info`), as referred to in the docstrings

Minor additional changes:

* removed some unused imports
@SimonBlanke SimonBlanke requested a review from fkiraly August 27, 2025 14:01
Adds integration for another learning task in `sktime` - time series
classification.

* `SktimeClassificationExperiment` experiment
* `TSCOptCV` TSC tuning algorithm that takes any `hyperactive` tuner

Since time series classification uses ordinary sklearn metrics, the
`experiments.integration` contents are refactored, moving utilities
concerned with `sklearn` metrics into a separate, private file
`_skl_metrics`.
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The strange thing is that the GitHub UI shows changes that should have been merged in earlier pull requests already - why is that?

Is this PR maybe from a branch where main has not been merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants