Update target python versions#58
Conversation
|
Hello @23pointsNorth, good idea! I ran all tests for 3.10 and 3.11 yesterday and I found the following problems:
I didn't expect this to blow up like this, but I am grateful, because I learned a lot reading about these problems :-) Let me know what you think about these problems. |
61235ac to
c75d536
Compare
|
Hi @SimonBlanke , As far as I know, as an open source project it makes no difference per se (i.e. not sure when would make sense to sunset versions)? Are there any timing tests? Would be nice to see if there is any speed difference between the versions :) |
Codecov ReportBase: 90.97% // Head: 90.97% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 15 15
Lines 654 654
=======================================
Hits 595 595
Misses 59 59 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hello @23pointsNorth, thanks for the contribution! :-)
Currently not, but I do not expect any significant speed-ups on our end. Usually the biggest part of the computation time is spend on the model inside the objective-function (the smbo might be an exception). But it would be interesting to see how it affects Hyperactive. |
|
Looking at the CI everything looks green, so hopefully, it wasn't too much of a hassle. Thanks for the great library! |
As per https://devguide.python.org/versions/ Python version 3.5 and 3.6 are EOL. It would make sense to continue testing on 3.6 -> 3.11