Skip to content

Fix karaoke highlight crash when editing the transcript #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maboa merged 1 commit into from
May 26, 2026
Merged

Fix karaoke highlight crash when editing the transcript #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,22 @@ <h3 class="font-bold text-lg">Caption Regeneration </h3>

const hyperaudioInstance = new HyperaudioLite("hypertranscript", "hyperplayer", minimizedMode, autoScroll, doubleClick, webMonetization, playOnClick);

// Patch for #294: if the library's polling chain runs while wordArr
// still references a span deleted by an in-progress edit, the original
// throws on word.n.parentNode.classList and the chain dies silently.
// Strip detached entries before delegating — the next debounced
// refreshHyperaudioInstance will rebuild wordArr from the live DOM.
const originalUpdateVisualState = hyperaudioInstance.updateTranscriptVisualState.bind(hyperaudioInstance);
hyperaudioInstance.updateTranscriptVisualState = function (currentTime) {
if (hyperaudioInstance.wordArr) {
const live = hyperaudioInstance.wordArr.filter(w => w.n && w.n.parentNode);
if (live.length !== hyperaudioInstance.wordArr.length) {
hyperaudioInstance.wordArr = live;
}
}
return originalUpdateVisualState(currentTime);
};

window.hyperaudioInstance = hyperaudioInstance;

const sanitisationCheck = function () {
Expand Down