Modernize Web Monetization integration (resolves #215, #194)#216
Merged
Conversation
The previous implementation injected <meta name="monetization" content="..."> tags using $-prefixed payment-pointer shorthand. Both the meta tag form and the shorthand syntax were deprecated by the Web Monetization spec in the 2023-09-20 draft, and Coil (the only widely-used WM agent that read them) shut down in March 2023. As a result, the feature was effectively dead in practice — no current Web Monetization agent reads what the code emits. Changes: - js/hyperaudio-lite.js now injects <link rel="monetization" href="..."> as required by the current Interledger Foundation spec. - active.html keeps Web Monetization enabled and demonstrates the feature, with data-wm attributes updated to full wallet URLs (https://ilp.uphold.com/... rather than $ilp.uphold.com/...). - index.html no longer enables Web Monetization and no longer carries data-wm attributes. Resolves #194. - videojs.html and vidstack.html had dangling data-wm attributes even though their webMonetization flag was already false. Removed. - README Web Monetization section updated: points readers at active.html as the example, explains the link-element approach, drops the obsolete payment-pointer shorthand from the snippet, and notes that visitors still need a Web Monetization browser extension since no browser ships native support. All 25 existing tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation injected tags using $-prefixed payment-pointer shorthand. Both the meta tag form and the shorthand syntax were deprecated by the Web Monetization spec in the 2023-09-20 draft, and Coil (the only widely-used WM agent that read them) shut down in March 2023. As a result, the feature was effectively dead in practice — no current Web Monetization agent reads what the code emits.
Changes:
js/hyperaudio-lite.js now injects as required by the current Interledger Foundation spec.
active.html keeps Web Monetization enabled and demonstrates the feature, with data-wm attributes updated to full wallet URLs (https://ilp.uphold.com/... rather than $ilp.uphold.com/...).
index.html no longer enables Web Monetization and no longer carries data-wm attributes. Resolves Remove example references to Web Monetization in default index.html #194.
videojs.html and vidstack.html had dangling data-wm attributes even though their webMonetization flag was already false. Removed.
README Web Monetization section updated: points readers at active.html as the example, explains the link-element approach, drops the obsolete payment-pointer shorthand from the snippet, and notes that visitors still need a Web Monetization browser extension since no browser ships native support.
All 25 existing tests pass.