Conversation
NikhilShahi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes the sandbox create payload shape sent to the API and normalizes new wire fields on
getDetail/list, which could break compatibility if server contracts differ.Overview
Supports sandbox resource sizing by adding optional
cpu,memoryMiB, anddiskMiBto image-basedsandboxes.create()while explicitly disallowing these fields for snapshot launches (runtime validation + type-level contract tests).The service now serializes these options to the API’s wire names (
vcpus,memMiB,diskSizeMiB) and normalizesgetDetail()/list()responses back to the SDK’scpu/memoryMiB/diskMiBfields;SandboxHandleexposes the new sizing getters. Documentation examples and package version are updated, and an e2e test verifies sizing is applied inside the runtime.Written by Cursor Bugbot for commit 0b04410. This will update automatically on new commits. Configure here.