Skip to content

Change runtime url#71

Merged
NikhilShahi merged 6 commits intomainfrom
change-runtime-url
Apr 14, 2026
Merged

Change runtime url#71
NikhilShahi merged 6 commits intomainfrom
change-runtime-url

Conversation

@Dingway98
Copy link
Copy Markdown
Contributor

@Dingway98 Dingway98 commented Apr 14, 2026


Open with Devin

Note

Medium Risk
Moderate risk because it changes how runtime HTTP/WebSocket URLs are constructed (including /sandbox prefixing and base-path handling), which could break sandbox runtime connectivity if edge cases are missed.

Overview
Adjusts sandbox runtime routing to correctly handle runtimes whose runtime.baseUrl may already include /sandbox/{sessionId}. The runtime transport now normalizes request paths (including query params) and resolveRuntimeTransportTarget rewrites paths to avoid double-prefixing or missing /sandbox, for both HTTP and WebSocket targets.

Updates exposed port URL generation to derive the session subdomain from the runtime base path (or runtime.host) so exposed URLs become https://{port}-{sessionId}.{host}/. Adds runtime-path helpers and updates e2e contract tests/fixtures accordingly, and bumps the package version to 0.89.3.

Reviewed by Cursor Bugbot for commit 7343c0f. Bugbot is set up for automated code reviews on this repo. Configure here.

cursor[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@NikhilShahi NikhilShahi merged commit 682cca6 into main Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants