Change runtime url#71
Merged
NikhilShahi merged 6 commits intomainfrom Apr 14, 2026
Merged
Conversation
NikhilShahi
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes how runtime HTTP/WebSocket URLs are constructed (including
/sandboxprefixing and base-path handling), which could break sandbox runtime connectivity if edge cases are missed.Overview
Adjusts sandbox runtime routing to correctly handle runtimes whose
runtime.baseUrlmay already include/sandbox/{sessionId}. The runtime transport now normalizes request paths (including query params) andresolveRuntimeTransportTargetrewrites paths to avoid double-prefixing or missing/sandbox, for both HTTP and WebSocket targets.Updates exposed port URL generation to derive the session subdomain from the runtime base path (or
runtime.host) so exposed URLs becomehttps://{port}-{sessionId}.{host}/. Addsruntime-pathhelpers and updates e2e contract tests/fixtures accordingly, and bumps the package version to0.89.3.Reviewed by Cursor Bugbot for commit 7343c0f. Bugbot is set up for automated code reviews on this repo. Configure here.