Skip to content

Fetch branding#74

Merged
AHarmlessPyro merged 7 commits intomainfrom
fetch_branding
Apr 21, 2026
Merged

Fetch branding#74
AHarmlessPyro merged 7 commits intomainfrom
fetch_branding

Conversation

@AHarmlessPyro
Copy link
Copy Markdown
Contributor

@AHarmlessPyro AHarmlessPyro commented Apr 21, 2026


Open in Devin Review

Note

Low Risk
Low risk: this is a TypeScript type-surface expansion (no runtime logic) plus a patch version bump, with the main risk being downstream compile-time incompatibilities for consumers relying on narrower unions.

Overview
Adds first-class branding extraction support to the Fetch type surface by introducing BrandingProfile (and related styling/personality/design-system types) and exposing it from src/types/index.ts.

Extends fetch output and response typings to include branding via a new FetchOutputBranding format and optional branding?: BrandingProfile fields on PageData and FetchResponseData. Also bumps the package version to 0.89.5.

Reviewed by Cursor Bugbot for commit 7bf7f22. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

⚠️ 1 issue in files not directly in the diff

⚠️ FetchOutputBranding not exported from types index (src/types/index.ts:280)

FetchOutputBranding is defined in src/types/web/common.ts:67-69 but is not re-exported from src/types/index.ts. Every other FetchOutput* interface (FetchOutputMarkdown, FetchOutputHtml, FetchOutputLinks, FetchOutputScreenshot, FetchOutputJson) is exported at src/types/index.ts:275-280. SDK consumers importing from @hyperbrowser/sdk/types won't have access to the FetchOutputBranding type.

View 1 additional finding in Devin Review.

Open in Devin Review

cursor[bot]

This comment was marked as resolved.

cursor[bot]

This comment was marked as resolved.

@AHarmlessPyro AHarmlessPyro merged commit 1ae51d7 into main Apr 21, 2026
1 of 2 checks passed
@AHarmlessPyro AHarmlessPyro deleted the fetch_branding branch April 21, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants