Fetch branding#74
Merged
AHarmlessPyro merged 7 commits intomainfrom Apr 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Devin Review found 1 potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ FetchOutputBranding not exported from types index (src/types/index.ts:280)
FetchOutputBranding is defined in src/types/web/common.ts:67-69 but is not re-exported from src/types/index.ts. Every other FetchOutput* interface (FetchOutputMarkdown, FetchOutputHtml, FetchOutputLinks, FetchOutputScreenshot, FetchOutputJson) is exported at src/types/index.ts:275-280. SDK consumers importing from @hyperbrowser/sdk/types won't have access to the FetchOutputBranding type.
View 1 additional finding in Devin Review.
NikhilShahi
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: this is a TypeScript type-surface expansion (no runtime logic) plus a patch version bump, with the main risk being downstream compile-time incompatibilities for consumers relying on narrower unions.
Overview
Adds first-class branding extraction support to the Fetch type surface by introducing
BrandingProfile(and related styling/personality/design-system types) and exposing it fromsrc/types/index.ts.Extends fetch output and response typings to include
brandingvia a newFetchOutputBrandingformat and optionalbranding?: BrandingProfilefields onPageDataandFetchResponseData. Also bumps the package version to0.89.5.Reviewed by Cursor Bugbot for commit 7bf7f22. Bugbot is set up for automated code reviews on this repo. Configure here.