fix(ci): handle pr-base env name in e2e workflow dispatch#78
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚅 Deployed to the ePDS-pr-78 environment in ePDS
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 38 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR updates the e2e GitHub Actions workflow to support a persistent Railway environment ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aspiers
force-pushed
the
fix/e2e-pr-base-url
branch
from
7ca4e5e to
cae0abe
Compare
Coverage Report for CI Build 24341195897Coverage remained the same at 31.681%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
The persistent pr-base Railway environment is named "pr-base", not "ePDS-pr-base". When manually dispatching e2e tests with "ePDS / ePDS-pr-base" (by analogy with the PR format), the derived URLs included an erroneous "epds-" prefix and hit 404s. - Normalise "ePDS-pr-base" → "pr-base" in the slug derivation - Add pr-base to the workflow_dispatch input description - Document pr-base usage in AGENTS.md and e2e/README.md - Fix stale e2e-pr.yml references → e2e-tests.yml Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aspiers
force-pushed
the
fix/e2e-pr-base-url
branch
from
cae0abe to
d0ec8ed
Compare
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
e2e/README.md (1)
150-156: Consider documenting the legacy-compatibleePDS / ePDS-pr-baseinput as accepted.Line [155] documents
ePDS / pr-base, but the workflow also acceptsePDS / ePDS-pr-basevia normalization. Listing it here as a compatibility alias would reduce operator confusion during manual dispatches.Suggested doc tweak
Use the exact string you see there. Accepted formats: - `ePDS / ePDS-pr-<N>` — standard PR environment name. - `ePDS / pr-<hash>-<N>` — Railway's collision-avoidance fallback, seen after a close/reopen or force-push inside the env-cleanup window. See [Railway discussion](https://station.railway.com/questions/pr-environment-name-format-change-causin-9aaa904f). - `ePDS / pr-base` — the persistent post-merge backstop environment. + - `ePDS / ePDS-pr-base` — compatibility alias; normalized to `pr-base`.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@e2e/README.md` around lines 150 - 156, Add the legacy-compatible alias `ePDS / ePDS-pr-base` to the accepted formats list (alongside the existing `ePDS / pr-base`) so the README documents both canonical and normalized legacy names; update the bullet list text where the formats are enumerated to include `ePDS / ePDS-pr-base` and a short note that it is a compatibility alias..github/workflows/e2e-tests.yml (1)
520-525: Harden pr-base normalization to be fully case-insensitive.The current condition handles "ePDS-pr-base" and "epds-pr-base" but leaves other mixed-case variants like "EPDS-pr-base" and "ePdS-pr-base" unnormalized. Lowercasing before comparison ensures all variants map deterministically to "pr-base".
Suggested hardening
- if [[ "$ENV_NAME" == "ePDS-pr-base" || "$ENV_NAME" == "epds-pr-base" ]]; then + if [[ "${ENV_NAME,,}" == "epds-pr-base" ]]; then ENV_NAME="pr-base" fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/e2e-tests.yml around lines 520 - 525, Normalize ENV_NAME to lowercase before comparison so all mixed-case variants map to "pr-base": create a lowercase copy (e.g. env_lc="${ENV_NAME,,}") and use that in the condition (if [[ "$env_lc" == "epds-pr-base" ]]) then set ENV_NAME="pr-base"; reference the ENV_NAME variable and the new env_lc local when making this change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/e2e-tests.yml:
- Around line 520-525: Normalize ENV_NAME to lowercase before comparison so all
mixed-case variants map to "pr-base": create a lowercase copy (e.g.
env_lc="${ENV_NAME,,}") and use that in the condition (if [[ "$env_lc" ==
"epds-pr-base" ]]) then set ENV_NAME="pr-base"; reference the ENV_NAME variable
and the new env_lc local when making this change.
In `@e2e/README.md`:
- Around line 150-156: Add the legacy-compatible alias `ePDS / ePDS-pr-base` to
the accepted formats list (alongside the existing `ePDS / pr-base`) so the
README documents both canonical and normalized legacy names; update the bullet
list text where the formats are enumerated to include `ePDS / ePDS-pr-base` and
a short note that it is a compatibility alias.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 446496b3-ffa3-4281-8ebb-ca20347094b2
📒 Files selected for processing (3)
.github/workflows/e2e-tests.ymlAGENTS.mde2e/README.md
1 participant
Summary
ePDS-pr-base→pr-basein the e2e workflow's URL slug derivation, so manually dispatching withenv_name="ePDS / ePDS-pr-base"works correctlyePDS / pr-baseto theworkflow_dispatchinput descriptionAGENTS.mdande2e/README.mde2e-pr.ymlfilename references →e2e-tests.ymlin both docsTest plan
env_name="ePDS / pr-base"and verify it passesenv_name="ePDS / ePDS-pr-base"and verify normalisation produces correct URLs🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
pr-baseenvironment format for test execution in addition to PR-specific formats.