test(e2e): login-hint-resolution feature scenarios#94
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 11 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚅 Deployed to the ePDS-pr-94 environment in ePDS
|
Coverage Report for CI Build 24675237166Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.3%) to 36.836%Details
Uncovered Changes
Coverage Regressions15 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Cover all five scenarios from login-hint-resolution.feature: email, handle, and DID hints on the query string; hint in the PAR body only; and unknown hints falling back to the email form. Rewrite the feature file to use the dynamic test account created by the Background instead of the previous hard-coded alice@example.com / alice.pds.test / did:plc:alice123 literals, which cannot be planted in the live test environment. Extend the demo OAuth client with `?login_hint=<raw>` and `?login_hint_location=query|body` query params so tests can drive the handle / DID / PAR-body code paths without a bespoke OAuth client. Existing `?email=` and `?handle=` behaviors are unchanged; the explicit override wins when present. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
aspiers
force-pushed
the
hyper-cucumber-all-features
branch
from
ff9d879 to
2d6abc7
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
The demo home page does not forward ?login_hint= query params to the login route, so navigating to demoUrl/?login_hint=... dropped the hint before PAR. Hit /api/oauth/login directly where rawLoginHint is read. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Matches the error code introduced in /api/oauth/login so users see a readable message instead of the "Unexpected error: …" fallback. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
1 participant
Summary
features/login-hint-resolution.feature(email/handle/DID hints on query string, hint in PAR body only, unknown hint fallback).alice@example.com/alice.pds.test/did:plc:alice123literals can't be planted in the live Railway test environment.?login_hint=<raw>and?login_hint_location=query|bodyso tests can exercise the handle / DID / PAR-body code paths without a bespoke OAuth client. Existing?email=/?handle=behavior is unchanged; the explicit?login_hint=override wins when provided.Test plan
pnpm lint && pnpm format:check && pnpm typecheck && pnpm testall pass locally🤖 Generated with Claude Code