Skip to content

Restore count #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bitbeckers merged 1 commit into from
Aug 31, 2024
Merged

Restore count #143

bitbeckers merged 1 commit into from
Aug 31, 2024

Conversation

@bitbeckers
Copy link
Collaborator

@bitbeckers bitbeckers commented Aug 31, 2024

When querying using filters, or when using pagination, count should not return the amount or returned rows, but the amount of rows matching the filter params.

This PR:

  • Defines dataQuery and countQuery builder
  • Implements data fetching buy calling both the data and count query in a single transaction
  • Cleans up some business logic

@bitbeckers bitbeckers merged commit eb21dfa into develop Aug 31, 2024
@bitbeckers bitbeckers deleted the fix/count_relevant_fields branch September 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitbeckers