File upload endpoint #205
Merged
File upload endpoint #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an upload endpoint to our API. This has been implemented using multer as a middleware for file validations and restrictions on file size. Basic happy/unhappy flow tests pass.
Increases coverage threshold based on updated test suite Updates the types used in lib/users to match updated API types Generated updated Swagger
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Add validations on file type and size
To gradually clean up the repo, we agreed on restructuring helpers from utils to more cleanly scoped libs. Additionally, added some tests
pheuberger
reviewed
Jan 3, 2025
Member
pheuberger
left a comment
pheuberger
left a comment
There was a problem hiding this comment.
I have some preliminary feedback on the controller. I haven't reviewed the tests yet and the later commits, but wanted to share already.
Member
|
@bitbeckers small pdfs(<1MB) were fine at all. |
Updates the UploadController to use custom errors. The custom errors are defined in a uploads lib directory and handles all cases found in the controller.
Updates the UploadController typedoc example to document different upload tools and the expected responses
Adds typeguards and updates the parsing of failed and successful file uploads for readability
Updates the test cases to test on the expanded upload result types. Additionally typedoc documentation was updated to document the error and the controller more accurately.
Collaborator
Author
Issues created #205 (comment) |
pheuberger
reviewed
Jan 20, 2025
pheuberger
reviewed
Jan 20, 2025
Member
pheuberger
left a comment
pheuberger
left a comment
There was a problem hiding this comment.
Nice, looks very clean. All my comments are non-blocking, so feel free to merge any time!
pheuberger
approved these changes
Jan 20, 2025
Collaborator
Author
|
Sorry @pheuberger but I need to resolve all non-blocking comments because they block the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to provide a basic IPFS upload endpoint to self-reported evaluations on hypercerts data. Primarily, it should allow impact creators to provide updates on the data represented withing an hypercert, like evaluation reports or proof of work/attendance/etc..