Merged
Conversation
- currently focuses on `GET` requests (punting on deseralizing bodies until we have #44 figured out, though `BodyParams` was added as a stand in) - param source precedence was implemented, with each subsequent source overwriting keys in ones proceeding it: `query`,` body`, `path` - params are parsed into `url.Values`, for consistency. #43 will go further and cast this into the appropriate types. - currently, nothing is calling `Params()`, the main entry point for parsing params from all sources -- this will change as all of the tickets that implment #3 come together fixes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GETrequests (punting on deseralizing bodiesuntil we have Bind Params to a given Endpoint #44 figured out, though
BodyParamswas added as a standin)
overwriting keys in ones proceeding it:
query,body,pathurl.Values, for consistency. Custom Types for Params #43 will gofurther and cast this into the appropriate types.
Params(), the main entry point forparsing params from all sources -- this will change as all of the
tickets that implment Params #3 come together
fixes #41