fix: handle the case when CUSTOM_OTELCOL_CONFIG_FILE is not specified
#1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ebe15cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🟢 Success (4/4 tests passed) [dashboard] This comment was generated from stably-runner-action |
wrn14897
force-pushed
the
warren/handle-the-case-when-custom-otelcol-config-file-env-not-specified
branch
from
74ef16f to
9bb0565
Compare
wrn14897
commented
Aug 19, 2025
|
|
||
| if (apiKeys && apiKeys.length > 0) { | ||
| // Build full configuration with all team API keys | ||
| const otelCollectorConfig: CollectorConfig = { |
Member
Author
There was a problem hiding this comment.
moved this config out of if block and removed all 'receivers' from the pipeline so that the collector can start even if the apiKeys is empty
wrn14897
commented
Aug 19, 2025
Comment on lines
+223
to
+230
| // TODO: prometheus needs to be authenticated | ||
| receivers: ['prometheus'], | ||
| processors: ['memory_limiter', 'batch'], | ||
| exporters: ['clickhouse'], | ||
| }, | ||
| 'logs/in': { | ||
| // TODO: fluentforward needs to be authenticated | ||
| receivers: ['fluentforward'], |
Member
Author
There was a problem hiding this comment.
keep the 'prometheus' and 'fluentforward' unauthed (default behavior). need to fix it in later PRs
…onfig-file-env-not-specified
knudtty
approved these changes
Aug 19, 2025
kodiakhq
bot
deleted the
warren/handle-the-case-when-custom-otelcol-config-file-env-not-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus fixing startup issue when the team isn't created yet
HDX-2238