fix: Multiline support for WHERE Input boxes #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 40e547c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
teeohhem
force-pushed
the
tom/multiline-inpurt-support
branch
from
8c61c33 to
7cee063
Compare
Contributor
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 213s
|
teeohhem
commented
Sep 26, 2025
| additionalSuggestions?: string[]; | ||
| queryHistoryType?: string; | ||
| parentRef?: HTMLElement | null; | ||
| allowMultiline?: boolean; |
Contributor
Author
There was a problem hiding this comment.
We don't want multiline to apply to all SQLInlineEditor instances for the sake of layout continuity.
…yperdx into tom/multiline-inpurt-support
brandon-pereira
approved these changes
Sep 29, 2025
Member
|
Tested this and it works really good! Nice job! |
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
# Summary This PR fixes a few bugs in the session search page: 1. Clicking ENTER now triggers a form submission on the session page for lucene conditions (SQL conditions already worked) 2. Clicking ENTER now triggers a form submission on the session side panel for both lucene and SQL conditions 3. The WHERE condition in the search sidebar is now interpreted in the correct `whereLanguage` instead of assuming lucene. Partially reverts #863, but I confirmed that the page-level search does not filter the sidepanel spans after this change. This PR also fixes the same issue (ENTER now submits forms) on the dashboard and services page. #1208 introduced the issue by preventing the ENTER event from bubbling up to the form when using `AutocompleteInput` / `SearchInputV2`. Closes HDX-2816 Closes HDX-2817 https://github.com/user-attachments/assets/b91bdb0f-e241-43c2-9854-88fbe43daec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: HDX-2427
Closes: HDX-1683
Also adds shift + enter support in these boxes to work within multilines