Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Nov 13, 2025

Summary

This PR fixes a few bugs in the session search page:

  1. Clicking ENTER now triggers a form submission on the session page for lucene conditions (SQL conditions already worked)
  2. Clicking ENTER now triggers a form submission on the session side panel for both lucene and SQL conditions
  3. The WHERE condition in the search sidebar is now interpreted in the correct whereLanguage instead of assuming lucene. Partially reverts fix: Client session search should not propagate to session replay events list #863, but I confirmed that the page-level search does not filter the sidepanel spans after this change.

This PR also fixes the same issue (ENTER now submits forms) on the dashboard and services page. #1208 introduced the issue by preventing the ENTER event from bubbling up to the form when using AutocompleteInput / SearchInputV2.

Closes HDX-2816
Closes HDX-2817

Screen.Recording.2025-11-12.at.9.32.09.PM.mov

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: 58ac26a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 13, 2025 2:26pm

@claude
Copy link

claude bot commented Nov 13, 2025

PR Review

No critical issues found.

The changes look good overall:

Strengths:

  • Correctly fixes the form submission issue by adding onSubmit props to SearchInputV2 and SQLInlineEditorControlled components
  • Properly fixes the whereLanguage handling in SessionSubpanel.tsx by using the correct language context instead of hardcoding 'lucene'
  • Changes are consistent across all affected pages (Sessions, Dashboard, Services)
  • The fix aligns with the existing pattern where onSubmit is called in AutocompleteInput.tsx:299 when Enter is pressed

Minor observations (non-blocking):

  • The changeset file correctly documents the patch-level change
  • All changes maintain existing TypeScript type safety
  • The dependency arrays in the useMemo hooks were correctly updated to include whereLanguage

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

E2E Test Results

All tests passed • 40 passed • 3 skipped • 320s

Status Count
✅ Passed 40
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@pulpdrew pulpdrew requested review from a team and brandon-pereira and removed request for a team November 13, 2025 11:54
Copy link
Member

@brandon-pereira brandon-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit c42a070 into main Nov 13, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the drew/fix-session-search branch November 13, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants