-
Notifications
You must be signed in to change notification settings - Fork 333
fix: Fix session search behavior #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 58ac26a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review✅ No critical issues found. The changes look good overall: Strengths:
Minor observations (non-blocking):
|
E2E Test Results✅ All tests passed • 40 passed • 3 skipped • 320s
|
8ca03d0 to
e2cd293
Compare
brandon-pereira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR fixes a few bugs in the session search page:
whereLanguageinstead of assuming lucene. Partially reverts fix: Client session search should not propagate to session replay events list #863, but I confirmed that the page-level search does not filter the sidepanel spans after this change.This PR also fixes the same issue (ENTER now submits forms) on the dashboard and services page. #1208 introduced the issue by preventing the ENTER event from bubbling up to the form when using
AutocompleteInput/SearchInputV2.Closes HDX-2816
Closes HDX-2817
Screen.Recording.2025-11-12.at.9.32.09.PM.mov