fix: Include connectionId in metadata cache key #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c6d0eda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pulpdrew
force-pushed
the
drew/include-connection-in-metadata-cache
branch
from
3cc0a9f to
0fec8ef
Compare
Contributor
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 230s
|
PR Review: Include connectionId in metadata cache key✅ No critical issues found. The changes are well-structured and consistently applied across all cache keys in the metadata layer: What was changed:
Quality observations:
This is a solid bug fix that properly isolates metadata by connection. |
pulpdrew
force-pushed
the
drew/include-connection-in-metadata-cache
branch
from
0fec8ef to
24e5e1a
Compare
pulpdrew
requested review from
a team and
brandon-pereira
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HDX-2573
This PR adds connection ID to the metadata cache key, to ensure that metadata is not shared across tables with the same name in different connections.
For example, previously when switching between otel_logs tables in different connections, filter values would not reload:
Screen.Recording.2025-10-15.at.4.26.43.PM.mov
Now they will:
Screen.Recording.2025-10-15.at.4.25.45.PM.mov