-
Notifications
You must be signed in to change notification settings - Fork 323
chore to move critical path files #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to easily track when core files are modified via path fixes HDX-2589
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: Move Critical Path Files to Core Folder✅ No critical issues found. This is a well-executed refactoring that moves core utility files (metadata.ts, renderChartConfig.ts, utils.ts) into a dedicated core/ folder within packages/common-utils/src/. What was verified:
Summary:This change improves code organization by grouping critical telemetry processing files together, making it easier to track changes to core functionality via path-based tooling. The refactor is purely structural with no logic changes. |
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 292s
|
wrn14897
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. We just need to fix unit tests
wrn14897
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
moves them into a core folder, this allows us to easily track when core files are modified via path
no changeset because no version bump required
fixes HDX-2589