Skip to content

Conversation

@brandon-pereira
Copy link
Member

@brandon-pereira brandon-pereira commented Oct 29, 2025

moves them into a core folder, this allows us to easily track when core files are modified via path

no changeset because no version bump required

fixes HDX-2589

…to easily track when core files are modified via path

fixes HDX-2589
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: fbde1ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 30, 2025 2:55pm

@claude
Copy link

claude bot commented Oct 29, 2025

PR Review: Move Critical Path Files to Core Folder

No critical issues found.

This is a well-executed refactoring that moves core utility files (metadata.ts, renderChartConfig.ts, utils.ts) into a dedicated core/ folder within packages/common-utils/src/.

What was verified:

  • ✅ Files properly moved from packages/common-utils/src/ to packages/common-utils/src/core/
  • ✅ All 54 import statements correctly updated across API and app packages
  • ✅ Internal imports within moved files use correct path aliases (@/core/...)
  • ✅ Test files properly updated with new import paths
  • ✅ TypeScript path mapping configured correctly (@/* → src/*)
  • ✅ No lingering references to old import paths
  • ✅ File structure follows TypeScript best practices

Summary:

This change improves code organization by grouping critical telemetry processing files together, making it easier to track changes to core functionality via path-based tooling. The refactor is purely structural with no logic changes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

E2E Test Results

All tests passed • 39 passed • 3 skipped • 292s

Status Count
✅ Passed 39
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Copy link
Member

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. We just need to fix unit tests

Copy link
Member

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kodiakhq kodiakhq bot merged commit 43dfb3a into main Oct 30, 2025
10 checks passed
@kodiakhq kodiakhq bot deleted the brandon/move-critical-path-deps branch October 30, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants