-
Notifications
You must be signed in to change notification settings - Fork 330
feat: Improve Service Maps #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 7a5baa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
E2E Test Results✅ All tests passed • 40 passed • 3 skipped • 300s
|
Code Review - PR #1353✅ Overall Assessment: No critical issues found. The changes look good and follow the project's patterns well: Positive observations:
Minor suggestions (non-blocking):
The implementation correctly addresses all stated goals and maintains consistency with the codebase architecture. |
dhable
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR makes a number of minor fixes and improvements to the Service Maps feature:
1 request), rather than approximate numbers (eg.~1 request). Closes HDX-2741.