Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Nov 12, 2025

Summary

This PR makes a number of minor fixes and improvements to the Service Maps feature:

  1. The Service Map now has its own tab in the side panel. This resolves usability issues such as the trace panel capturing scroll events and appearing too large on the side panel. Closes HDX-2785, Closes HDX-2732.
  2. On single-trace service maps (eg. the one on the side panel), request counts are now rendered as exact numbers (eg. 1 request), rather than approximate numbers (eg. ~1 request). Closes HDX-2741.
  3. Service map viewport bounds are now reset when the input data changes (typically when the source or sampling level changes). Closes HDX-2778.
  4. Service maps now have an empty state. Closes HDX-2739.
Screenshot 2025-11-11 at 11 00 05 PM Screenshot 2025-11-11 at 11 05 13 PM

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

🦋 Changeset detected

Latest commit: 7a5baa8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 14, 2025 4:40pm

@pulpdrew pulpdrew changed the title Drew/service map panel feat: Improve Service Maps Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

E2E Test Results

All tests passed • 40 passed • 3 skipped • 300s

Status Count
✅ Passed 40
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@claude
Copy link

claude bot commented Nov 12, 2025

Code Review - PR #1353

Overall Assessment: No critical issues found.

The changes look good and follow the project's patterns well:

Positive observations:

  • ✅ Proper use of Mantine UI components (Stack, Group, Badge, Text, Flex, Center, Loader)
  • ✅ TypeScript interfaces properly defined for all new components
  • ✅ Good separation of concerns with new ServiceMapSidePanel component
  • ✅ Error boundaries properly maintained
  • ✅ Conditional rendering with proper null checks
  • ✅ ReactFlow wrapped in ReactFlowProvider as required
  • ✅ useReactFlow hook usage follows React Flow patterns
  • ✅ Empty state handling added
  • ✅ Loading states preserved

Minor suggestions (non-blocking):

  • ℹ️ In ServiceMapSidePanel.tsx:44, the conditional could be simplified from ? ... : null to && ... for consistency with React patterns
  • ℹ️ Consider memoizing the enableServiceMap boolean if performance becomes a concern (likely negligible)

The implementation correctly addresses all stated goals and maintains consistency with the codebase architecture.

@pulpdrew pulpdrew requested review from a team and teeohhem and removed request for a team November 12, 2025 04:20
Copy link
Contributor

@dhable dhable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit a7e150c into main Nov 14, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the drew/service-map-panel branch November 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants