Skip to content

fix: Fix session search behavior #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

fix: Fix session search behavior #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2cd293
fix: Fix session search behavior
pulpdrew Nov 13, 2025
aeb6131
fix: Fix form submission on dashboard and services page search input
pulpdrew Nov 13, 2025
58ac26a
Merge branch 'main' into drew/fix-session-search
kodiakhq[bot] Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-timers-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Fix session search behavior
1 change: 1 addition & 0 deletions packages/app/src/DBDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,7 @@ function DBDashboardPage({ presetConfig }: { presetConfig?: Dashboard }) {
placeholder="Search your events w/ Lucene ex. column:foo"
enableHotkey
data-testid="search-input"
onSubmit={onSubmit}
/>
)
}
Expand Down
1 change: 1 addition & 0 deletions packages/app/src/ServicesDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,7 @@ function ServicesDashboardPage() {
language="lucene"
placeholder="Search your events w/ Lucene ex. column:foo"
enableHotkey
onSubmit={onSubmit}
/>
}
/>
Expand Down
9 changes: 6 additions & 3 deletions packages/app/src/SessionSubpanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ export default function SessionSubpanel({
select: commonSelect,
from: traceSource.from,
dateRange: [start, end],
whereLanguage: 'lucene',
whereLanguage,
where: searchedQuery,
timestampValueExpression: traceSource.timestampValueExpression,
implicitColumnExpression: traceSource.implicitColumnExpression,
Expand All @@ -376,7 +376,7 @@ export default function SessionSubpanel({
traceSource.connection,
start,
end,
// whereLanguage,
whereLanguage,
searchedQuery,
tab,
highlightedEventsFilter,
Expand All @@ -402,7 +402,7 @@ export default function SessionSubpanel({
select: commonSelect,
from: traceSource.from,
dateRange: [start, end],
whereLanguage: 'lucene',
whereLanguage,
where: searchedQuery,
timestampValueExpression: traceSource.timestampValueExpression,
implicitColumnExpression: traceSource.implicitColumnExpression,
Expand All @@ -425,6 +425,7 @@ export default function SessionSubpanel({
traceSource.connection,
start,
end,
whereLanguage,
searchedQuery,
tab,
highlightedEventsFilter,
Expand Down Expand Up @@ -495,6 +496,7 @@ export default function SessionSubpanel({
language="sql"
size="xs"
enableHotkey
onSubmit={handleSubmit(handleWhereSubmit)}
/>
) : (
<SearchInputV2
Expand All @@ -505,6 +507,7 @@ export default function SessionSubpanel({
size="xs"
placeholder="Search your events w/ Lucene ex. column:foo"
enableHotkey
onSubmit={handleSubmit(handleWhereSubmit)}
/>
)}
</form>
Expand Down
1 change: 1 addition & 0 deletions packages/app/src/SessionsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ export default function SessionsPage() {
<SearchInputV2
tableConnection={tcFromSource(traceTrace)}
control={control}
onSubmit={onSubmit}
name="where"
onLanguageChange={lang =>
setValue('whereLanguage', lang, {
Expand Down
Loading