Skip to content

Conversation

@brandon-pereira
Copy link
Member

Very minor PR which fixes 2 HTML structure issues (div under p, button under button).

Before:
Screenshot 2025-11-13 at 6 58 22 PM

After:
Non prop errors (on search page at least)

@brandon-pereira brandon-pereira requested review from a team and dhable and removed request for a team November 14, 2025 00:29
@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: 8b2ff21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 14, 2025 0:59am

@claude
Copy link

claude bot commented Nov 14, 2025

PR Review: Fix prop warnings

No critical issues found.

This PR correctly fixes HTML structure validation issues by:

  • Converting UnstyledButton to render as div with role="button" in DBRowTableIconButton.tsx:54,57 (fixes button-in-button nesting)
  • Converting Text to render as div in SQLInlineEditor.tsx:330 (fixes div-in-p nesting)
  • Updating E2E tests to match new DOM structure

The approach using Mantine's component prop is idiomatic and maintains accessibility with proper ARIA roles. Changes are minimal and targeted.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

E2E Test Results

All tests passed • 40 passed • 3 skipped • 310s

Status Count
✅ Passed 40
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

MikeShi42
MikeShi42 previously approved these changes Nov 14, 2025
@kodiakhq kodiakhq bot merged commit 3fb5ef7 into main Nov 14, 2025
14 of 15 checks passed
@kodiakhq kodiakhq bot deleted the feature/fix-prop-warnings branch November 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants