Skip to content

fix prop warnings #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2025
Merged

fix prop warnings #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c673d2
fix prop warnings
brandon-pereira Nov 14, 2025
fde56e1
add changeset
brandon-pereira Nov 14, 2025
c641291
Merge branch 'main' into feature/fix-prop-warnings
brandon-pereira Nov 14, 2025
8b2ff21
fix failing tests
brandon-pereira Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/chatty-parents-drum.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

Small fix for html structure nesting issues
2 changes: 2 additions & 0 deletions packages/app/src/components/DBTable/DBRowTableIconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ export const DBRowTableIconButton: React.FC<DBRowTableIconButtonProps> = ({
>
<UnstyledButton
onClick={handleClick}
component="div"
className={baseClasses}
tabIndex={tabIndex}
role="button"
>
{isActive ? <IconCheck size={iconSize} /> : children}
</UnstyledButton>
Expand Down
1 change: 1 addition & 0 deletions packages/app/src/components/SQLInlineEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ export default function SQLInlineEditor({
style={{
whiteSpace: 'nowrap',
}}
component="div"
>
<Tooltip label={tooltipText} disabled={!tooltipText}>
<Flex align="center" gap={2}>
Expand Down
4 changes: 2 additions & 2 deletions packages/app/tests/e2e/features/shared/multiline.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
if (config.mode === 'SQL') {
const scopedContainer = formSelector ? container : page;
const whereLabel = scopedContainer.locator(
`p.mantine-Text-root:has-text("${whereText}")`,
`div.mantine-Text-root:has-text("${whereText}")`,
);
await expect(whereLabel).toBeVisible();
}
Expand All @@ -122,7 +122,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
? (() => {
const scopedContainer = formSelector ? container : page;
const whereContainer = scopedContainer.locator(
`div:has(p.mantine-Text-root:has-text("${whereText}"))`,
`div:has(div.mantine-Text-root:has-text("${whereText}"))`,
);
return whereContainer.locator('.cm-editor').first();
})()
Expand Down