Skip to content

Conversation

@wrn14897
Copy link
Member

@wrn14897 wrn14897 commented Nov 18, 2025

will migrate to clickhouse/clickstack-xxx repos in next PR

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: d725403

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 18, 2025 5:17pm

@claude
Copy link

claude bot commented Nov 18, 2025

PR Review

No critical issues found.

The changes cleanly add new image tag variables (NEXT__IMAGE_NAME_DOCKERHUB) for migration to ClickHouse ClickStack repositories while maintaining existing hyperdx/ tags. The implementation is consistent across all build targets (local, all-in-one, otel-collector) and their nightly variants.

Verification:

  • Removed variables (IMAGE_NAME, LOCAL_IMAGE_NAME, ALL_IN_ONE_IMAGE_NAME, OTEL_COLLECTOR_IMAGE_NAME) are not referenced elsewhere in the codebase
  • docker-compose files only use *_DOCKERHUB variables which remain unchanged
  • All Makefile targets properly use the new NEXT_* variables for dual tagging

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

E2E Test Results

All tests passed • 38 passed • 3 skipped • 411s

Status Count
✅ Passed 38
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

View full report →

@kodiakhq kodiakhq bot merged commit 3f29e33 into main Nov 18, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the warren/push-clickstack-images branch November 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants