fix: Fix double value for isRootSpan facet #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00e8e2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ No critical issues found. The fix correctly preserves the type of values in the Set (string | boolean) instead of stringifying them, which was causing duplicate entries when boolean The change is consistent with how facet values are handled elsewhere in the code (DBSearchPageFilters.tsx:991-999). |
Contributor
E2E Test Results✅ All tests passed • 46 passed • 3 skipped • 270s
|
pulpdrew
requested review from
a team and
brandon-pereira
and removed request for
a team
brandon-pereira
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where the the
isRootSpanfilter facet would show duplicatetruevalues, but (interestingly) only if the value had never been pinned before.Before
After