fix: Respect date range URL params on Services dashboard#1594
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 563625d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review✅ No critical issues found. The fix correctly addresses the bug where Services dashboard was resetting to default time range on page load. The implementation:
The logic is sound: |
Contributor
E2E Test Results✅ All tests passed • 60 passed • 4 skipped • 744s
Tests ran across 4 shards in parallel. |
pulpdrew
requested review from
a team and
brandon-pereira
and removed request for
a team
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
Closes HDX-3189 # Summary This PR fixes a bug that caused the services dashboard to reset to the default time range on each page load, rather than respecting the URL date range params. The cause was that a couple of `useEffects` were firing at page load, and submitting a new date range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HDX-3189
Summary
This PR fixes a bug that caused the services dashboard to reset to the default time range on each page load, rather than respecting the URL date range params.
The cause was that a couple of
useEffectswere firing at page load, and submitting a new date range.