Skip to content

fix: Validate column names when saving dashboard tiles#1615

Merged
kodiakhq[bot] merged 1 commit intomainfrom
fleon/hdx-3222
Jan 16, 2026
Merged

fix: Validate column names when saving dashboard tiles#1615
kodiakhq[bot] merged 1 commit intomainfrom
fleon/hdx-3222

Conversation

@fleon
Copy link
Copy Markdown
Contributor

@fleon fleon commented Jan 16, 2026

Similar to #1597, verify column names for validation errors when saving dashboard tiles too.

CleanShot.2026-01-16.at.13.32.07.mp4

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 16, 2026

🦋 Changeset detected

Latest commit: 701d064

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 16, 2026 0:34am

Review with Vercel Agent

@fleon fleon requested a review from pulpdrew January 16, 2026 12:32
@claude
Copy link
Copy Markdown

claude Bot commented Jan 16, 2026

PR Review

No critical issues found.

The implementation correctly adds metric name validation to the save flow (matching the existing play button validation from PR #1597). The code follows established patterns:

  • Extracted validateMetricNames helper function for reusability ✓
  • Properly validates metric sources with empty metricName when metricType is set ✓
  • Test coverage includes save button validation scenario ✓
  • Dependencies correctly updated in handleSave useCallback ✓

Minor observations (non-blocking):

  • Test uses mocked components which is consistent with existing test patterns
  • Validation logic appropriately returns early to prevent save when validation fails

@fleon
Copy link
Copy Markdown
Contributor Author

fleon commented Jan 16, 2026

@pulpdrew Similar to #1597, but for saving dashboard tiles. Abstracts the logic in a common function too.

cc @teeohhem

@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 60 passed • 4 skipped • 778s

Status Count
✅ Passed 60
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq Bot merged commit 190c66b into main Jan 16, 2026
13 checks passed
@kodiakhq kodiakhq Bot deleted the fleon/hdx-3222 branch January 16, 2026 13:11
knudtty pushed a commit that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants