fix: Validate column names when saving dashboard tiles#1615
Merged
kodiakhq[bot] merged 1 commit intomainfrom Jan 16, 2026
Merged
fix: Validate column names when saving dashboard tiles#1615kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 701d064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review✅ No critical issues found. The implementation correctly adds metric name validation to the save flow (matching the existing play button validation from PR #1597). The code follows established patterns:
Minor observations (non-blocking):
|
Contributor
Author
Contributor
E2E Test Results✅ All tests passed • 60 passed • 4 skipped • 778s
Tests ran across 4 shards in parallel. |
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
Similar to #1597, verify column names for validation errors when saving dashboard tiles too. https://github.com/user-attachments/assets/ff9ec648-47da-433f-abe0-cc779aba1a76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1597, verify column names for validation errors when saving dashboard tiles too.
CleanShot.2026-01-16.at.13.32.07.mp4