-
Notifications
You must be signed in to change notification settings - Fork 351
feat: debounce highlighted attribute validation query #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: debounce highlighted attribute validation query #1626
Conversation
🦋 Changeset detectedLatest commit: 1d24bb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review✅ No critical issues found. The implementation correctly debounces the validation query with a 1-second delay and uses Minor observations (non-blocking):
|
E2E Test Results✅ All tests passed • 59 passed • 4 skipped • 771s
Tests ran across 4 shards in parallel. |
fleon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Though my preference is to have a shorter debounce interval, say 400-500ms, its not a strong preference.
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice improvement!
4982ef5 to
1d24bb2
Compare
Follow up to #1576 after feedback from @MikeShi42.
With these changes, validation queries run either when the "Validate expression" button is clicked, or 1 second after the input value was changed for either the expression or the alias.
Untitled.mov