Optimize materialized column lookup for expression aliases by vinzee · Pull Request #1959 · hyperdxio/hyperdx

vinzee · 2026-03-21T01:17:19Z

Summary

Improve the materialized column optimization by allowing it to be applied when WITH clauses are expression aliases (i.e., isSubquery: false). Previously, any WITH clause would disable this optimization. This change ensures that materialized columns are still considered for performance benefits when the WITH clause does not represent a subquery.

Screenshots or video

Before	After

How to test locally or on Vercel

Create a ClickHouse table with a materialized column, e.g.:

ALTER TABLE otel_logs ADD COLUMN awesome_attribute String MATERIALIZED LogAttributes['awesome_attribute']

Open the Explore view for logs (/search)
Add a filter for awesome_attribute (or LogAttributes['awesome_attribute'])
Inspect the POST body of /clickhouse-proxy requests in the network tab:
- Before fix: The histogram (time chart) query contains LogAttributes['awesome_attribute'] (full map scan), while the search results query correctly uses awesome_attribute.
- After fix: Both the histogram and search results queries use awesome_attribute (the materialized column).

References

Linear Issue: Materialized column optimization skipped for histogram in Explore view #1957
Related PRs:

Improve the materialized column optimization by allowing it to be applied when `WITH` clauses are expression aliases (i.e., `isSubquery: false`). Previously, any `WITH` clause would disable this optimization. This change ensures that materialized columns are still considered for performance benefits when the `WITH` clause does not represent a subquery.

vercel · 2026-03-21T01:17:24Z

@vinzee is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

changeset-bot · 2026-03-21T01:17:27Z

🦋 Changeset detected

Latest commit: 677b768

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hyperdx/common-utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-03-21T01:19:00Z

PR Review

✅ No critical issues found.

The core change is minimal and correct:

hasSubqueryCte() properly handles the optional isSubquery field — since it defaults to true (per the type comment "default assume true"), w.isSubquery !== false correctly treats undefined as a subquery CTE and only allows the optimization when explicitly false.
Both renderSelectList and renderWhereExpressionStr are updated consistently.
Tests cover both the new path (expression alias CTEs → optimization enabled) and the existing subquery CTE path (optimization disabled).
Changeset is included.

vercel · 2026-03-21T23:53:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Mar 22, 2026 9:05pm

wrn14897

Please run yarn changeset to add a changeset

wrn14897 · 2026-03-22T00:07:06Z

+      await renderChartConfig(config, mockMetadata, querySettings);
+      expect(
+        mockMetadata.getMaterializedColumnsLookupTable,
+      ).toHaveBeenCalled();


it would be nice to verify the rendered SQL has pipe_id

wrn14897 · 2026-03-22T01:55:19Z

-  // supported for queries using CTEs so skip the metadata fetch if there are CTE objects in the config.
+  // supported for queries using subquery CTEs so skip the metadata fetch if there are subquery CTE
+  // objects in the config. Expression aliases (isSubquery: false) do not affect the base table.
+  const hasSubqueryCte = chartConfig.with?.some(w => w.isSubquery !== false);


nit: can we move this logic to a shared method?

Extract a shared hasSubqueryCte() helper that only skips the optimization for true subquery CTEs, and fix unit tests verifying both paths.

wrn14897

Thanks for the contribution!

wrn14897 · 2026-03-22T18:03:58Z

@claude fix linting error

github-actions · 2026-03-22T18:05:15Z

Claude Code is working…

I'll analyze this and get back to you.

View job run

wrn14897 · 2026-03-22T18:12:19Z

@vinzee there is a lint error in the test file. could you fix it? https://github.com/hyperdxio/hyperdx/actions/runs/23395356725/job/68092930851?pr=1959

This commit refactors several E2E tests by adding blank lines for improved readability and consistency. It also updates the .gitignore file to ignore `package-lock.json`, preventing it from being committed to the repository. [Generated via Zoox Intelligence / `zi-gcm --edit`]

## Summary Improve the materialized column optimization by allowing it to be applied when `WITH` clauses are expression aliases (i.e., `isSubquery: false`). Previously, any `WITH` clause would disable this optimization. This change ensures that materialized columns are still considered for performance benefits when the `WITH` clause does not represent a subquery. ### Screenshots or video | Before | After | | :----- | :---- | | | | ### How to test locally or on Vercel 1. Create a ClickHouse table with a materialized column, e.g.: ```sql ALTER TABLE otel_logs ADD COLUMN awesome_attribute String MATERIALIZED LogAttributes['awesome_attribute'] ``` 2. Open the Explore view for logs (`/search`) 3. Add a filter for `awesome_attribute` (or `LogAttributes['awesome_attribute']`) 4. Inspect the POST body of `/clickhouse-proxy` requests in the network tab: - Before fix: The histogram (time chart) query contains `LogAttributes['awesome_attribute']` (full map scan), while the search results query correctly uses `awesome_attribute`. - After fix: Both the histogram and search results queries use `awesome_attribute` (the materialized column). ### References - Linear Issue: #1957 - Related PRs:

## Summary Improve the materialized column optimization by allowing it to be applied when `WITH` clauses are expression aliases (i.e., `isSubquery: false`). Previously, any `WITH` clause would disable this optimization. This change ensures that materialized columns are still considered for performance benefits when the `WITH` clause does not represent a subquery. ### Screenshots or video | Before | After | | :----- | :---- | | | | ### How to test locally or on Vercel 1. Create a ClickHouse table with a materialized column, e.g.: ```sql ALTER TABLE otel_logs ADD COLUMN awesome_attribute String MATERIALIZED LogAttributes['awesome_attribute'] ``` 2. Open the Explore view for logs (`/search`) 3. Add a filter for `awesome_attribute` (or `LogAttributes['awesome_attribute']`) 4. Inspect the POST body of `/clickhouse-proxy` requests in the network tab: - Before fix: The histogram (time chart) query contains `LogAttributes['awesome_attribute']` (full map scan), while the search results query correctly uses `awesome_attribute`. - After fix: Both the histogram and search results queries use `awesome_attribute` (the materialized column). ### References - Linear Issue: #1957 - Related PRs: Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>

wrn14897 reviewed Mar 21, 2026

View reviewed changes

vercel Bot deployed to Preview March 21, 2026 23:57 View deployment

wrn14897 reviewed Mar 22, 2026

View reviewed changes

Address PR comments

6295606

Extract a shared hasSubqueryCte() helper that only skips the optimization for true subquery CTEs, and fix unit tests verifying both paths.

wrn14897 previously approved these changes Mar 22, 2026

View reviewed changes

vercel Bot deployed to Preview March 22, 2026 18:05 View deployment

vinzee dismissed wrn14897’s stale review via 677b768 March 22, 2026 19:16

vercel Bot deployed to Preview March 22, 2026 21:05 View deployment

wrn14897 approved these changes Mar 22, 2026

View reviewed changes

wrn14897 added the automerge label Mar 22, 2026

kodiakhq Bot merged commit 6936ef8 into hyperdxio:main Mar 22, 2026
15 checks passed

Conversation

vinzee commented Mar 21, 2026

Summary

Screenshots or video

How to test locally or on Vercel

References

Uh oh!

vercel Bot commented Mar 21, 2026

Uh oh!

changeset-bot Bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

vercel Bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wrn14897 left a comment

Choose a reason for hiding this comment

Uh oh!

wrn14897 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

vinzee Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

wrn14897 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

vinzee Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

wrn14897 left a comment

Choose a reason for hiding this comment

Uh oh!

wrn14897 commented Mar 22, 2026

Uh oh!

github-actions Bot commented Mar 22, 2026

Uh oh!

wrn14897 commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Mar 21, 2026 •

edited

Loading

github-actions Bot commented Mar 21, 2026 •

edited

Loading

vercel Bot commented Mar 21, 2026 •

edited

Loading