Skip to content

Implement reusable Heatmap chart with Event Deltas support#2102

Closed
alex-fedotyev wants to merge 6 commits intomainfrom
cursor/heatmap-event-deltas-f0cd
Closed

Implement reusable Heatmap chart with Event Deltas support#2102
alex-fedotyev wants to merge 6 commits intomainfrom
cursor/heatmap-event-deltas-f0cd

Conversation

@alex-fedotyev
Copy link
Copy Markdown
Contributor

@alex-fedotyev alex-fedotyev commented Apr 10, 2026

Summary

This update hardens the heatmap + event-deltas query path to avoid invalid SQL generation in delta mode on trace/demo data.

  • Sanitizes timestampValueExpression before passing config into DBDeltaChart so trailing AS ... aliases are not reused in grouped clauses.
  • Prevents DBDeltaChart from inheriting incompatible chart fields by overriding the shared config in DBHeatmapWithDeltasChart:
    • with: undefined
    • select: 'tuple(_part, _part_offset)'
    • groupBy: undefined
    • having: undefined
    • granularity: undefined
  • Adds focused unit coverage for timestamp alias sanitization in DBHeatmapWithDeltasChart.
  • Updates chart preview test mocking to keep heatmap preview assertions aligned with the composite component behavior.

Screenshots or video

Will attach updated end-to-end verification artifacts in a follow-up after Playwright/manual validation confirms rendered heatmap data in both:

  • Chart Explorer heatmap path
  • Dashboard tile heatmap path

How to test locally or on Vercel

  1. Open the PR preview deployment and create/login to an account (random credentials are fine on fresh demo env).
  2. In Search/Chart explorer, switch to Heatmap and run on demo trace data; verify the heatmap renders and no GROUP BY ... AS __hdx_time_bucket / SpanId not under aggregate error appears.
  3. Add a dashboard tile using Heatmap from the same dataset and verify the tile renders actual heatmap data.

References

  • Linear Issue: HDX-3993
  • Related PRs:

Linear Issue: HDX-3993

Open in Web Open in Cursor 

Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 11, 2026 1:16am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 10, 2026

⚠️ No Changeset found

Latest commit: 07de447

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

E2E Test Results

All tests passed • 130 passed • 3 skipped • 1049s

Status Count
✅ Passed 130
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Co-authored-by: Alex Fedotyev <alex-fedotyev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants