feat: Show alert execution errors in the UI#2132
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 700bab2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔴 Tier 4 — CriticalTouches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
PR Review✅ No critical issues found. This is a well-implemented feature with comprehensive tests (unit, integration, and E2E). A few minor observations:
The error accumulation flow (query errors → early return + |
b4a599b to
251f25a
Compare
E2E Test Results✅ All tests passed • 147 passed • 3 skipped • 1110s
Tests ran across 4 shards in parallel. |
251f25a to
4139b24
Compare
4139b24 to
700bab2
Compare
Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
## Summary This PR updates the recent alert runner error persistence + display (#2132) to hardcode webhook and unknown-type errors. The raw error messages could contain potentially sensitive information, so we won't persist them or show them in the UI. <img width="664" height="183" alt="Screenshot 2026-04-20 at 7 13 57 AM" src="https://github.com/user-attachments/assets/0f4f600b-2cdd-47e5-ba72-cec4dbc40423" /> ### How to test locally or on Vercel This can be tested locally by running an alert with an invalid webhook destination.
Summary
This PR persists and displays errors that occur during alert execution.
Previously, when an alert execution error'd (due to bad SQL, invalid webhook configuration, etc), users would have no way to debug the issue - they'd just see that the error was missing AlertHistory entries on the alert page. Now, the user will see an error icon, with the option to view a more detailed error message.
Details
The errors are persisted on the Alert documents (rather than the AlertHistory documents) because
Screenshots or video
How to test locally or on Vercel
This must be tested locally, since alerts are not supported in the preview environment.
To see the notification content, run an echo server locally and create a webhook that targets it (http://localhost:3000):
Interesting cases to test:
References