fix: prevent false "data source not set" error on markdown dashboard tiles

[vinzee]

Problem

Markdown tiles created via the external API or MCP always show the following error:

The data source for this tile is not set. Edit the tile to select a data source.

...even though markdown tiles do not require a data source. Tiles created through the UI do not exhibit this problem.

Root Cause

convertToInternalTileConfig stores source: '' on the internal config for markdown tiles to satisfy the BuilderSavedChartConfig TypeScript type, which requires a source field:

case 'markdown':
  internalConfig = {
    displayType: DisplayType.Markdown,
    markdown: externalConfig.markdown,
    source: '',   // <-- required by type, but semantically empty
    ...
  } satisfies BuilderSavedChartConfig;

The frontend's isSourceUnset check in DBDashboardPage used
!chart.config.source, which evaluates to true for an empty string,
incorrectly triggering the error banner for every API-created markdown tile:

const isSourceUnset =
  !!chart.config &&
  isBuilderSavedChartConfig(chart.config) &&
  !chart.config.source;  // true for '', fires on all markdown tiles

Solution

Add a displayType !== DisplayType.Markdown guard to isSourceUnset so
markdown tiles are never considered to have an unset source:

const isSourceUnset =
  !!chart.config &&
  isBuilderSavedChartConfig(chart.config) &&
  chart.config.displayType !== DisplayType.Markdown &&
  !chart.config.source;

Tests

• packages/common-utils: unit tests for isBuilderSavedChartConfig and
  the isSourceUnset pattern, verifying that markdown tiles evaluate to
  false (no error shown) even when source is ''
• packages/api: unit tests for convertToInternalTileConfig covering
  the markdown tile conversion path and tile layout field preservation

[vercel]

@vinzee is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0adae28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/common-utils	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Review

✅ No critical issues found.

Targeted, well-scoped fix for the false "data source not set" banner on markdown tiles. Notes:

• ✓ Good encapsulation — extracting displayTypeRequiresSource() in common-utils/src/guards.ts:42 is cleaner than the inline displayType !== DisplayType.Markdown shown in the PR description, and the doc comment correctly flags it as the canonical location for future sourceless display types.
• ✓ Test coverage — both the guard unit tests and the API conversion tests directly exercise the bug path (markdown tile with source: '').
• ✓ Changeset present with correct package scope (@hyperdx/app, @hyperdx/common-utils).
• 💡 Optional follow-up (non-blocking): packages/app/src/components/ChartEditor/utils.ts:216,227,244 still has three inline form.displayType !== DisplayType.Markdown checks that could adopt the new helper for consistency. Fine to defer to a separate PR given this one is intentionally scoped.

[brandon-pereira]

LGTM - thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	May 6, 2026 11:11pm