Skip to content

Use PageHeader title on list pages #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elizabetdev wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Use PageHeader title on list pages #2345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/page-header-title-list-pages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperdx/app': patch
---

chore: use `PageHeader` `title` prop on Alerts, Dashboards, and Saved Searches list pages for consistency with the shared header API.
2 changes: 1 addition & 1 deletion packages/app/src/AlertsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export default function AlertsPage() {
<Head>
<title>Alerts - {brandName}</title>
</Head>
<PageHeader>Alerts</PageHeader>
<PageHeader title="Alerts" />
<div className="my-4" style={{ flex: 1 }}>
{isLoading ? (
<div className="text-center my-4 fs-8">Loading...</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/Dashboards/DashboardsListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export default function DashboardsListPage() {
<Head>
<title>Dashboards - {brandName}</title>
</Head>
<PageHeader>Dashboards</PageHeader>
<PageHeader title="Dashboards" />
<Container
maw={1200}
py="lg"
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/SavedSearches/SavedSearchesListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default function SavedSearchesListPage() {
<Head>
<title>Saved Searches - {brandName}</title>
</Head>
<PageHeader>Saved Searches</PageHeader>
<PageHeader title="Saved Searches" />
<Container
maw={1200}
py="lg"
Expand Down
Loading