fix: map alias with filters

[knudtty]

Summary

If you try and add a filter for an existing column that is a map access column, (ex: ResourceAttributes['service.name']), ClickHouse will return the column as arrayElement(ResourceAttributes, 'service.name'). Previously filters were defined in SQL, but now they are lucene, which means it doesn't automatically translate anymore.

We could either make the filters aware of how to parse and translate that statement, or add an alias to the SELECT if a map is accessed. This PR adds both.

Screenshots or video

export-1780324637704.mp4

How to test on Vercel preview

Preview routes:

Steps:

1. Add a `ResourceAttributes['service.name']
2. Hover over the column titled ResourceAttributes['service.name'] on any row
3. Click "toggle filter"
4. Observe that the behavior is handled correctly

References

• Linear Issue: Closes HDX-4411

[changeset-bot]

🦋 Changeset detected

Latest commit: 8035128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/common-utils	Patch
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Jun 1, 2026 8:54pm
hyperdx-storybook	Ready	Preview, Comment	Jun 1, 2026 8:54pm

[github-actions]

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

• Cross-layer change: touches frontend (packages/app) + shared utils (packages/common-utils)

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats

• Production files changed: 2
• Production lines changed: 39 (+ 112 in test files, excluded from tier calculation)
• Branch: aaron/fix-map-alias-with-filters
• Author: knudtty

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

E2E Test Results

✅ All tests passed • 190 passed • 3 skipped • 1342s

Status	Count
✅ Passed	190
❌ Failed	0
⚠️ Flaky	5
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

[github-actions]

Deep Review

🟡 P2 — recommended

• packages/common-utils/src/core/metadata.ts:1799 — parts[1].replaceAll("'", '') accesses parts[1] without a length check; an input like arrayElement(foo) (single argument, no comma) passes the prefix/suffix guard and throws TypeError: Cannot read properties of undefined, propagating out of addMapAliasesToSelect and any other parseKeyPath caller (useAutoCompleteOptions, useDashboardFilters, searchFilters, DBSearchPageFilters/utils).
  • Fix: Guard with if (parts.length !== 2 || parts[1] == null) return [key]; before destructuring, and add a regression test for the no-comma case.
  • _{correctness, testing, kieran-typescript}
• packages/common-utils/src/core/metadata.ts:1798 — inner.split(',') is not quote- or paren-aware, so a nested expression like arrayElement(coalesce(A, B), 'k') parses to ['arrayElement(coalesce(A', 'B)'] and addMapAliasesToSelect then emits malformed SQL ... as "coalesce(A['B)']"; a key value containing a comma ('a,b') is silently truncated.
  • Fix: Use a paren/quote-aware split (e.g., reuse splitAndTrimWithBracket on inner) or anchor the key by regex on the trailing ') so the column identifier and key are extracted without naïve splitting.
  • _{correctness, testing}

🔵 P3 nitpicks (3)

• packages/common-utils/src/core/metadata.ts:1799 — replaceAll("'", '') strips every single quote in the key value rather than the boundary pair, so a key carrying a literal apostrophe (e.g., ClickHouse-escaped 'O''Brien') canonicalizes differently from the bracket-form branch above and breaks the parse-and-compare invariant for the same logical attribute.
  • Fix: Strip only the surrounding quotes — e.g., parts[1].startsWith("'") && parts[1].endsWith("'") ? parts[1].slice(1, -1) : parts[1] — to match the surgical slicing used by the bracket-form branches.
  • _{correctness, maintainability, kieran-typescript}
• packages/app/src/components/DBRowTable.tsx:1618 — the typeof base.select === 'string' guard skips the DerivedColumn[] branch of SelectList; today every audited array-form caller sets an explicit alias so the structured-alias path in renderChartConfig handles them, but a future array-form caller that subscripts a Map without alias would silently regress with no type-level signal.
  • Fix: Either alias unaliased array entries through the same helper, or assert at the call site that DerivedColumn.valueExpression containing [ must carry an alias.
  • _{kieran-typescript}
• packages/common-utils/src/core/metadata.ts:1783 — parseKeyPath now has three sibling string-pattern branches with slightly different defensive posture (precise slicing on bracket forms, replaceAll on the function-call form); harmless today but heading toward a small ad-hoc parser if a fourth ClickHouse rendering form (tupleElement, mapValues, nested arrayElement) is added later.
  • Fix: When the next render form lands, extract a tokenizer rather than adding another startsWith arm.
  • _{maintainability, kieran-typescript}

---

Reviewers (8): correctness, testing, maintainability, project-standards, agent-native, learnings-researcher, kieran-typescript, previous-comments.

Testing gaps:

• No parseKeyPath test for arrayElement(X) with zero commas (the input that crashes today).
• No parseKeyPath test for an arrayElement key whose value contains a comma, e.g., arrayElement(SpanAttributes, 'a,b').
• No parseKeyPath test for nested-call input, e.g., arrayElement(coalesce(A, B), 'k').
• No integration test wiring addMapAliasesToSelect through mergedConfigObj and asserting the arrayElement-rendered column round-trips to filter matching end-to-end.

[brandon-pereira]

LGTM