Skip to content

build(deps): update tss-esapi and revert policysigned workaround#29

Merged
hyperfinitism merged 2 commits intomainfrom
fix/revert-policysigned
Apr 10, 2026
Merged

build(deps): update tss-esapi and revert policysigned workaround#29
hyperfinitism merged 2 commits intomainfrom
fix/revert-policysigned

Conversation

@hyperfinitism
Copy link
Copy Markdown
Owner

@hyperfinitism hyperfinitism commented Apr 10, 2026

Changes

- Update tss-esapi to commit: 2c36f10, which fixes the policy_signed API.
- Revert the changes (workaround) to policysigned.rs in commit: 35c3fb2.

Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
@hyperfinitism hyperfinitism requested a review from Copilot April 10, 2026 12:36
@hyperfinitism hyperfinitism self-assigned this Apr 10, 2026
@hyperfinitism hyperfinitism added the dependencies Dependency-related items label Apr 10, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the policysigned command to use high-level tss-esapi abstractions instead of raw FFI, improving safety and removing manual memory management. Feedback highlights opportunities to handle negative expiration values, optimize Nonce allocations, and replace unsafe ticket serialization with the Marshall trait.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f45b9c5a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the tss-esapi dependency to a specific upstream git revision that fixes the policy_signed() wrapper API, and then removes the previously-added raw-ESYS FFI workaround in the policysigned subcommand to return to the safe wrapper.

Changes:

  • Pin tss-esapi / tss-esapi-sys to upstream git rev 2c36f103… to pick up the policy_signed() fix.
  • Revert src/cmd/policysigned.rs back to using tss_esapi::Context::policy_signed() and policy_get_digest(), removing raw FFI calls and manual ESYS allocation/free logic.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/cmd/policysigned.rs Replaces raw ESYS calls with the fixed tss-esapi wrapper and aligns the command flow with other policy subcommands.
Cargo.toml Switches tss-esapi from crates.io to a pinned git revision containing the upstream fix.
Cargo.lock Updates lock entries to reflect the git-sourced tss-esapi and tss-esapi-sys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hyperfinitism hyperfinitism force-pushed the fix/revert-policysigned branch 2 times, most recently from cff5dbd to b1a45d7 Compare April 10, 2026 13:08
Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
@hyperfinitism hyperfinitism force-pushed the fix/revert-policysigned branch from b1a45d7 to e2f4109 Compare April 10, 2026 13:15
@hyperfinitism hyperfinitism merged commit 93a1793 into main Apr 10, 2026
25 checks passed
@hyperfinitism hyperfinitism deleted the fix/revert-policysigned branch April 10, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency-related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants