Conversation
|
Nice! Looks like the transport init code is a lot simpler now! I'll test this soon. Did you have a look in tests ? I think helpers might need some changes too ? |
|
I updated the examples, but it seemed to compile fine as is (which was my goal to make it work with my downstream project). Since you’ve got a major refactor coming in I think it can just wait to see which drops first, quinn 0.8.0 or the h3 refactor. |
a9b8bd2 to
1f22583
Compare
|
@stammw I rebased and updated the tests package. the "test connect" test is failing now with a generic error. "h3::Error { code: H3_STREAM_CREATION_ERROR, cause: ApplicationClosed(ApplicationClose { error_code: 0, reason: b"" }) }" I tried working out the exact issue but I'm very unfamiliar with the manual async style polling code. On my real world application though it seems to work just fine with the update. |
|
All right, I'll have a look at this. |
|
Could you use |
stammw
left a comment
There was a problem hiding this comment.
Almost ready! Can you please make sure other server implementations still answer the client example ?
|
And also: Now the CI doesn't pass because the new version of rustls uses combinators on booleans. Can you add a commit like this one g2p/rustls-native-certs@0e1a013 ? |
|
Did you check that server and client examples still work together ? |
|
The only missing thing is the client example against server example case. Then we can merge it. It appears to be broken: |
stammw
left a comment
There was a problem hiding this comment.
Looks like Github actions takes this as a float and removes the trailing 0...
|
Thanks! |
quinn had some api changes, so I've updated h3 to work with the new api on the master branch. marked as WIP since there hasn't been an 0.8.0 release with the new api yet.